Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependabot config #15668

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

dprotaso
Copy link
Member

Fixing the config after merging - #15475

@knative-prow knative-prow bot requested review from izabelacg and skonto December 30, 2024 23:00
@dprotaso
Copy link
Member Author

/assign @skonto

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 30, 2024
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.55%. Comparing base (df03027) to head (aab9fd1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15668      +/-   ##
==========================================
+ Coverage   83.51%   83.55%   +0.04%     
==========================================
  Files         219      219              
  Lines       17427    17427              
==========================================
+ Hits        14554    14562       +8     
+ Misses       2502     2494       -8     
  Partials      371      371              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

/retest

patterns:
- "*"
patterns:
- "*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Although both are accepted by yaml, probably adding space for array items is mor ereadable, also as in the example here.

@skonto
Copy link
Contributor

skonto commented Jan 7, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
Copy link

knative-prow bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Contributor

skonto commented Jan 8, 2025

/override ?

Copy link

knative-prow bot commented Jan 8, 2025

@skonto: skonto unauthorized: /override is restricted to Repo administrators.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Contributor

skonto commented Jan 8, 2025

Error: Unable to download artifact(s): Artifact not found for name: artifacts
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

@dprotaso could you override the failing test (I have no rights) or do you know why it didnt keep the artifact around?

@dprotaso
Copy link
Member Author

dprotaso commented Jan 8, 2025

@dprotaso could you override the failing test (I have no rights) or do you know why it didnt keep the artifact around?

It's a 'best' effort cache. We need to re-kick off the build step first

@knative-prow knative-prow bot merged commit 79f8c3f into knative:main Jan 8, 2025
63 of 64 checks passed
@dprotaso
Copy link
Member Author

dprotaso commented Jan 8, 2025

lol we hit a weird prow bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants