Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.15] Upgrade the hack tool to fix the patch release issue #15724

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Jan 22, 2025

As the infra CI upgraded to Go 1.23, the hack tool failed to patch release the branch of 1.15. This PR upgraded the hack tool for this 1.15 branch to fix the issue.

@knative-prow knative-prow bot requested review from izabelacg and ReToCode January 22, 2025 15:28
@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.59%. Comparing base (19ad0d8) to head (4b87967).
Report is 1 commits behind head on release-1.15.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15   #15724      +/-   ##
================================================
+ Coverage         83.55%   83.59%   +0.04%     
================================================
  Files               219      219              
  Lines             17445    17445              
================================================
+ Hits              14576    14583       +7     
+ Misses             2499     2493       -6     
+ Partials            370      369       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso dprotaso closed this Jan 22, 2025
@dprotaso dprotaso reopened this Jan 22, 2025
@dprotaso
Copy link
Member

/lgtm
/approve

Copy link

knative-prow bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2025
@dprotaso
Copy link
Member

/override "test (v1.28.x, kourier-tls, runtime)"

Copy link

knative-prow bot commented Jan 22, 2025

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • test (v1.28.x, kourier-tls, runtime)

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • License Compliance
  • build-tests_serving_release-1.15
  • istio-latest-no-mesh-tls_serving_release-1.15
  • istio-latest-no-mesh_serving_release-1.15
  • style / suggester / github_actions
  • style / suggester / yaml
  • tide
  • unit-tests_serving_release-1.15
  • upgrade-tests_serving_release-1.15

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "test (v1.28.x, kourier-tls, runtime)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@houshengbo
Copy link
Contributor Author

/override "test (v1.28.x, kourier-tls, runtime)"

Copy link

knative-prow bot commented Jan 22, 2025

@houshengbo: houshengbo unauthorized: /override is restricted to Repo administrators.

In response to this:

/override "test (v1.28.x, kourier-tls, runtime)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

/override "istio-latest-no-mesh_serving_release-1.15"
/override "gateway-api-latest_serving_release-1.15"
/override "kourier-stable_serving_release-1.15"

Copy link

knative-prow bot commented Jan 22, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: gateway-api-latest_serving_release-1.15, istio-latest-no-mesh_serving_release-1.15, kourier-stable_serving_release-1.15

In response to this:

/override "istio-latest-no-mesh_serving_release-1.15"
/override "gateway-api-latest_serving_release-1.15"
/override "kourier-stable_serving_release-1.15"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

/override "contour-latest_serving_release-1.15"

Copy link

knative-prow bot commented Jan 22, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: contour-latest_serving_release-1.15

In response to this:

/override "contour-latest_serving_release-1.15"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 3870dcd into knative:release-1.15 Jan 22, 2025
129 of 131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants