-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.15] Upgrade the hack tool to fix the patch release issue #15724
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #15724 +/- ##
================================================
+ Coverage 83.55% 83.59% +0.04%
================================================
Files 219 219
Lines 17445 17445
================================================
+ Hits 14576 14583 +7
+ Misses 2499 2493 -6
+ Partials 370 369 -1 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "test (v1.28.x, kourier-tls, runtime)" |
@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "test (v1.28.x, kourier-tls, runtime)" |
@houshengbo: houshengbo unauthorized: /override is restricted to Repo administrators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "istio-latest-no-mesh_serving_release-1.15" |
@dprotaso: Overrode contexts on behalf of dprotaso: gateway-api-latest_serving_release-1.15, istio-latest-no-mesh_serving_release-1.15, kourier-stable_serving_release-1.15 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "contour-latest_serving_release-1.15" |
@dprotaso: Overrode contexts on behalf of dprotaso: contour-latest_serving_release-1.15 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3870dcd
into
knative:release-1.15
As the infra CI upgraded to Go 1.23, the hack tool failed to patch release the branch of 1.15. This PR upgraded the hack tool for this 1.15 branch to fix the issue.