Tests to make sure we pass through fields of corev1.Container #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though ContainerSpec accepts all fields of core/v1/Container, the controller will silently overwrite some fields, like Name, Resources, Ports, and VolumeMounts. This will cause confusions if the users expect their settings to be effective. This change disallows specifying those fields to avoid the confusions.
|
@grantr take a look? thanks |
|
Oops, missed this one @tcnghia, 👀 now |
grantr
suggested changes
Feb 28, 2018
| @@ -147,6 +167,10 @@ func TestCreateConfigurationsCreatesRevision(t *testing.T) { | |||
| t.Errorf("rev service was not %s", config.Spec.Template.Spec.Service) | |||
| } | |||
|
|
|||
| if !reflect.DeepEqual(rev.Spec, config.Spec.Template.Spec) { | |||
There was a problem hiding this comment.
use cmp.Diff here. It gives a nice message showing the differences between objects. Here's an example:
| @@ -158,6 +176,16 @@ func TestCreateRevCreatesStuff(t *testing.T) { | |||
| func(t *testing.T) { | |||
| for _, c := range p.Spec.Containers { | |||
| if c.Image == rev.Spec.ContainerSpec.Image { | |||
| // Make a copy and removed fields set by the controller. | |||
| container.Ports = nil | ||
| container.VolumeMounts = nil | ||
| // Verify that all other fields match revision container spec. | ||
| if !reflect.DeepEqual(container, rev.Spec.ContainerSpec) { |
grantr
approved these changes
Feb 28, 2018
| @@ -158,6 +171,12 @@ func TestCreateRevCreatesStuff(t *testing.T) { | |||
| func(t *testing.T) { | |||
| for _, c := range p.Spec.Containers { | |||
| if c.Image == rev.Spec.ContainerSpec.Image { | |||
| // Ignoring fields set by Elafros controller. | |||
| ignored := cmpopts.IgnoreFields(corev1.Container{}, "Name", "Ports", "Resources", "VolumeMounts") | |||
There was a problem hiding this comment.
I like the change to using IgnoreFields here!
There was a problem hiding this comment.
thanks about cmp.Diff suggestion 👍
I am pretty new to Go, so would love to receive lots of recommendations like these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176