Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 0 from distribution type metric boundaries #4593

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Remove 0 from distribution type metric boundaries #4593

merged 1 commit into from
Jul 2, 2019

Conversation

yanweiguo
Copy link
Contributor

Fixes a potential bug: census-ecosystem/opencensus-go-exporter-stackdriver#98. The same error already happens in some cases.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 2, 2019
@knative-prow-robot knative-prow-robot added area/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2019
knative-prow-robot
knative-prow-robot reviewed Jul 2, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanweiguo: 0 warnings.

In response to this:

Fixes a potential bug: census-ecosystem/opencensus-go-exporter-stackdriver#98. The same error already happens in some cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vagababov
vagababov reviewed Jul 2, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov, yanweiguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019
@knative-prow-robot knative-prow-robot merged commit 13e8541 into knative:master Jul 2, 2019
@yanweiguo yanweiguo deleted the fix_bucket branch October 24, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@vagababov vagababov vagababov left review comments

@lichuqiang lichuqiang Awaiting requested review from lichuqiang

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@vagababov vagababov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanweiguo @knative-prow-robot @vagababov @googlebot