Skip to content

Commit

Permalink
not all volume mounts are readonly (#72)
Browse files Browse the repository at this point in the history
we want the language here to allow for volume mounts that support write (ie. emptyDir)

Thus we moved the requirements to the volume's source
  • Loading branch information
dprotaso authored Sep 23, 2021
1 parent 5250f51 commit 42f8aeb
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion specs/serving/knative-api-specification-1.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -2275,7 +2275,7 @@ Max: 1
</td>
<td>bool
</td>
<td>Must be true. Defaults to true.
<td>Mutability & default value is defined by the volume source type.
</td>
<td>REQUIRED, if volumes is supported.
</td>
Expand Down Expand Up @@ -2338,6 +2338,8 @@ Max: 1
## ConfigMapVolumeSource
When mounted to a container <a href="#volumemount">VolumeMount.readOnly</a> MUST only accept `true`.
<table>
<tr>
<td><strong>FieldName</strong>
Expand Down Expand Up @@ -2393,6 +2395,8 @@ Max: 1
## SecretVolumeSource
When mounted to a container <a href="#volumemount">VolumeMount.readOnly</a> MUST only accept `true`.
<table>
<tr>
<td><strong>FieldName</strong>
Expand Down Expand Up @@ -2448,6 +2452,8 @@ Max: 1
## ProjectedVolumeSource
When mounted to a container <a href="#volumemount">VolumeMount.readOnly</a> MUST only accept `true`.
<table>
<tr>
<td><strong>FieldName</strong>
Expand Down

0 comments on commit 42f8aeb

Please sign in to comment.