Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace CSS Classes #42

Closed
aarreedd opened this issue Jun 2, 2014 · 3 comments
Closed

Namespace CSS Classes #42

aarreedd opened this issue Jun 2, 2014 · 3 comments

Comments

@aarreedd
Copy link

aarreedd commented Jun 2, 2014

Some of the RRSSB wordpress plugin users are encountering problems when their theme or another plugin have a CSS class with the same name as one in the RRSSB plugin. For instance 'icon' is common and often causes conflict. If users have other social sharing buttons on their page then the classes 'facebook','twitter','linkdin', etc often conflict as well. If we prefix all of the classes with 'rrssb-' these problems would be resolved.

I could change this in just the wordpress plugin but I would like to keep the changes between the wordpress plugin and the original RRSSB project to a minimum. Also, this change may help others avoid problems when integrating RRSSB directly into their sites or when using one of the other third-party versions.

  • aarreedd
@dbox
Copy link
Contributor

dbox commented Jun 18, 2014

@alan-reed You want to take a stab at this and submit pull request?

dbox added a commit that referenced this issue Oct 27, 2014
dbox added a commit that referenced this issue Oct 27, 2014
@dbox
Copy link
Contributor

dbox commented Oct 27, 2014

added

@dbox dbox closed this as completed Oct 27, 2014
@stevenmusumeche
Copy link

This broke backwards-compatibility with version 1.6.0, seems like a minor version release shouldn't do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants