Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add search bar component #290

Merged
merged 40 commits into from
Dec 19, 2024
Merged

feat: Add search bar component #290

merged 40 commits into from
Dec 19, 2024

Conversation

Trishu-Patel
Copy link
Contributor

@Trishu-Patel Trishu-Patel commented Dec 3, 2024

No description provided.

@Trishu-Patel Trishu-Patel added the enhancement New feature or request label Dec 3, 2024
packages/ember-core/src/components/form/search.gts Outdated Show resolved Hide resolved
packages/ember-core/src/components/form/search.gts Outdated Show resolved Hide resolved
packages/ember-core/src/components/form/search.gts Outdated Show resolved Hide resolved
packages/ember-core/src/components/form/search.gts Outdated Show resolved Hide resolved
TSenter
TSenter previously approved these changes Dec 17, 2024
@Trishu-Patel Trishu-Patel force-pushed the trishu-autocomplete branch 3 times, most recently from 4f31634 to f9a8a2d Compare December 18, 2024 12:46
packages/ember-core/src/components/form/search.gts Outdated Show resolved Hide resolved
packages/ember-core/src/components/form/search.gts Outdated Show resolved Hide resolved
apps/docs-app/app/components/f/form/search.gts Outdated Show resolved Hide resolved
apps/docs-app/app/components/f/form/search.gts Outdated Show resolved Hide resolved
apps/docs-app/app/components/f/form/search.gts Outdated Show resolved Hide resolved
@Trishu-Patel Trishu-Patel force-pushed the trishu-autocomplete branch 2 times, most recently from f1f240f to a4daaf6 Compare December 19, 2024 14:53
@Trishu-Patel Trishu-Patel force-pushed the trishu-autocomplete branch 2 times, most recently from 22e81ee to f8e7ddc Compare December 19, 2024 15:17
@Trishu-Patel Trishu-Patel requested a review from TSenter December 19, 2024 15:33
@TSenter TSenter mentioned this pull request Dec 19, 2024
@@ -276,6 +267,15 @@ export default class extends Component {
@value={{this.searchTimeout}}
@onInput={{fn this.update "searchTimeout"}}
/>
<Args.Action
@name="onQuery"
@description="A function that return a array of strings or objects options"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@description="A function that return a array of strings or objects options"
@description="A function that return an array of string or object options"

Copy link
Contributor

@TSenter TSenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@TSenter TSenter enabled auto-merge (squash) December 19, 2024 19:04
@TSenter TSenter merged commit f21f7a1 into main Dec 19, 2024
10 checks passed
@TSenter TSenter deleted the trishu-autocomplete branch December 19, 2024 19:06
@TSenter TSenter mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants