-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add search bar component #290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trishu-Patel
force-pushed
the
trishu-autocomplete
branch
from
December 3, 2024 20:42
dbd20c8
to
6c0ca58
Compare
TSenter
requested changes
Dec 17, 2024
TSenter
previously approved these changes
Dec 17, 2024
Trishu-Patel
force-pushed
the
trishu-autocomplete
branch
from
December 17, 2024 20:15
401ea43
to
9522649
Compare
Trishu-Patel
force-pushed
the
trishu-autocomplete
branch
3 times, most recently
from
December 18, 2024 12:46
4f31634
to
f9a8a2d
Compare
Trishu-Patel
force-pushed
the
trishu-autocomplete
branch
from
December 18, 2024 12:48
f9a8a2d
to
16033ff
Compare
TSenter
requested changes
Dec 18, 2024
apps/test-app/tests/integration/components/form/search-test.gts
Outdated
Show resolved
Hide resolved
Trishu-Patel
force-pushed
the
trishu-autocomplete
branch
2 times, most recently
from
December 19, 2024 14:53
f1f240f
to
a4daaf6
Compare
Trishu-Patel
force-pushed
the
trishu-autocomplete
branch
2 times, most recently
from
December 19, 2024 15:17
22e81ee
to
f8e7ddc
Compare
Trishu-Patel
force-pushed
the
trishu-autocomplete
branch
from
December 19, 2024 15:21
f8e7ddc
to
308db24
Compare
Closed
TSenter
requested changes
Dec 19, 2024
@@ -276,6 +267,15 @@ export default class extends Component { | |||
@value={{this.searchTimeout}} | |||
@onInput={{fn this.update "searchTimeout"}} | |||
/> | |||
<Args.Action | |||
@name="onQuery" | |||
@description="A function that return a array of strings or objects options" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
@description="A function that return a array of strings or objects options" | |
@description="A function that return an array of string or object options" |
TSenter
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.