-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement base and mktg card components #31
Conversation
c8935da
to
055d09d
Compare
8c6b05b
to
c386199
Compare
packages/ember-test-app/tests/integration/components/card-test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would like to try to combine the horizontal component and vertical component and use the @vertical
flag to simplify the component API. We are going to break out the <:start> and <:end> slots for the content where start is the top or left element and end is the bottom or right element. We also want to extract the price logic out and have a <:callout> slot and an argument for callout alignment.
31718ee
to
ee26e17
Compare
This is done now! |
ee26e17
to
ed0e7fe
Compare
db0c677
to
df5eca1
Compare
dc6c57b
to
52c04b9
Compare
This PR includes a base card component which contains structural layout for a card header and body as well as parameters for @ isClickable and @ onClick.
There is a mktg/card component that has a @ horizontal parameter to determine orientation. Vertical orientation will be default since that is most commonly seen in the mock-ups. It also contains named yield blocks of callout, start, and end as well as a parameter for leftAlignCallout on the vertical orientation.