Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement base and mktg card components #31

Merged
merged 14 commits into from
Aug 1, 2024
Merged

Conversation

ChesneyJulian
Copy link
Contributor

@ChesneyJulian ChesneyJulian commented Jul 25, 2024

This PR includes a base card component which contains structural layout for a card header and body as well as parameters for @ isClickable and @ onClick.
image

There is a mktg/card component that has a @ horizontal parameter to determine orientation. Vertical orientation will be default since that is most commonly seen in the mock-ups. It also contains named yield blocks of callout, start, and end as well as a parameter for leftAlignCallout on the vertical orientation.
image
image

@ChesneyJulian ChesneyJulian changed the title Chesney card components feat: Implement base and mktg card components Jul 26, 2024
@ChesneyJulian ChesneyJulian force-pushed the chesney-card-components branch from c8935da to 055d09d Compare July 26, 2024 15:07
@ChesneyJulian ChesneyJulian marked this pull request as ready for review July 26, 2024 15:21
@ChesneyJulian ChesneyJulian force-pushed the chesney-card-components branch 2 times, most recently from 8c6b05b to c386199 Compare July 29, 2024 15:17
packages/ember-test-app/app/templates/index.hbs Outdated Show resolved Hide resolved
packages/ember/package.json Outdated Show resolved Hide resolved
packages/ember/src/components/card.gts Outdated Show resolved Hide resolved
Copy link
Contributor

@Thomas-Jean Thomas-Jean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to try to combine the horizontal component and vertical component and use the @vertical flag to simplify the component API. We are going to break out the <:start> and <:end> slots for the content where start is the top or left element and end is the bottom or right element. We also want to extract the price logic out and have a <:callout> slot and an argument for callout alignment.

@ChesneyJulian ChesneyJulian force-pushed the chesney-card-components branch from 31718ee to ee26e17 Compare July 31, 2024 13:34
@ChesneyJulian
Copy link
Contributor Author

We would like to try to combine the horizontal component and vertical component and use the @vertical flag to simplify the component API. We are going to break out the <:start> and <:end> slots for the content where start is the top or left element and end is the bottom or right element. We also want to extract the price logic out and have a <:callout> slot and an argument for callout alignment.

This is done now!

@ChesneyJulian ChesneyJulian force-pushed the chesney-card-components branch from db0c677 to df5eca1 Compare July 31, 2024 16:09
@ChesneyJulian ChesneyJulian force-pushed the chesney-card-components branch from dc6c57b to 52c04b9 Compare July 31, 2024 18:28
@lnicely lnicely merged commit 044d433 into main Aug 1, 2024
9 checks passed
@lnicely lnicely deleted the chesney-card-components branch August 1, 2024 19:05
@TSenter TSenter added this to the Beta Release (v0.0.0) milestone Aug 2, 2024
@TSenter TSenter added the enhancement New feature or request label Aug 22, 2024
@TSenter TSenter added internal Internal changes or things that don't fit in any other category enhancement New feature or request and removed enhancement New feature or request internal Internal changes or things that don't fit in any other category labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants