feat: Implement icon component #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSenter
reviewed
Aug 1, 2024
|
Per Tyler - can we modify this to take an additional argument for showing the bubble/not showing the bubble? |
ChesneyJulian
force-pushed
the
chesney-icon-bubble
branch
from
711236a to
05e989f
Compare
ChesneyJulian
changed the title
lnicely
reviewed
Aug 2, 2024
ChesneyJulian
force-pushed
the
chesney-icon-bubble
branch
2 times, most recently
from
c063e8f to
8c17663
Compare
ChesneyJulian
force-pushed
the
chesney-icon-bubble
branch
from
8c17663 to
87a53b7
Compare
ChesneyJulian
commented
Aug 2, 2024
ChesneyJulian
force-pushed
the
chesney-icon-bubble
branch
from
5215a41 to
dbd0bb1
Compare
TSenter
requested changes
Aug 5, 2024
ChesneyJulian
force-pushed
the
chesney-icon-bubble
branch
from
7593c49 to
6a9a401
Compare
TSenter
approved these changes
Aug 5, 2024
TSenter
added
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component predefines sizing, padding and font size for icons. It has params for color, type, circular, and backgroundColor. If circular is true and no backgroundColor is passed, the backgroundColor will default to the subtle version of the icon color. The color params have types that match Bootstrap's color options. The type param utilizes the NrgIconValue type. The circular param determines if the icon has a circle background with additional padding and color.