Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add form select component #56

Merged
merged 14 commits into from
Aug 15, 2024
Merged

feat: Add form select component #56

merged 14 commits into from
Aug 15, 2024

Conversation

KeithClinard
Copy link
Member

No description provided.

@KeithClinard KeithClinard force-pushed the keith-dropdown branch 2 times, most recently from 55f7688 to 88d4f06 Compare August 7, 2024 20:04
@Thomas-Jean
Copy link
Contributor

Thomas-Jean commented Aug 9, 2024

The width of the dropdown items doesn't take the full width of the dropdown element above it.

If I add a width: 100% to the dropdown-menu I get:

Screenshot 2024-08-09 at 1 30 38 PM

Edit:

Disabled also doesn't stop me from selecting or showing options on the freestyle form

packages/design-system/src/_forms.scss Outdated Show resolved Hide resolved
packages/ember-test-app/app/router.ts Outdated Show resolved Hide resolved
packages/ember-test-app/app/templates/components.hbs Outdated Show resolved Hide resolved
packages/ember/src/components/form/select.gts Outdated Show resolved Hide resolved
packages/ember/src/components/form/select.gts Outdated Show resolved Hide resolved
packages/ember/src/components/form/select.gts Show resolved Hide resolved
packages/ember/src/components/form/select.gts Outdated Show resolved Hide resolved
packages/ember/src/components/form/select.gts Show resolved Hide resolved
apps/ember-test-app/app/components/f/form/select.gts Outdated Show resolved Hide resolved
packages/ember/src/components/form/select.gts Show resolved Hide resolved
packages/ember/src/components/form/select.gts Outdated Show resolved Hide resolved
packages/ember/src/components/form/select.gts Outdated Show resolved Hide resolved
packages/ember/src/components/form/select.gts Outdated Show resolved Hide resolved
packages/ember/src/components/form/select.gts Outdated Show resolved Hide resolved
Copy link
Contributor

@TSenter TSenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really really like how the select works in the docs app. This is really cool!

packages/ember/src/components/form/select.gts Outdated Show resolved Hide resolved
packages/ember/src/components/form/select.gts Outdated Show resolved Hide resolved
packages/ember/src/components/form/select.gts Outdated Show resolved Hide resolved
packages/ember/translations/en-us.json Outdated Show resolved Hide resolved
packages/ember/src/components/form/select.gts Outdated Show resolved Hide resolved
@TSenter TSenter merged commit bb370b4 into main Aug 15, 2024
9 checks passed
@TSenter TSenter deleted the keith-dropdown branch August 15, 2024 12:51
@TSenter TSenter added the enhancement New feature or request label Aug 22, 2024
@TSenter TSenter added this to the Alpha Release (v0.0.0) milestone Aug 22, 2024
@TSenter TSenter removed the enhancement New feature or request label Aug 23, 2024
@TSenter TSenter added internal Internal changes or things that don't fit in any other category enhancement New feature or request and removed internal Internal changes or things that don't fit in any other category labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants