-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add form select component #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeithClinard
force-pushed
the
keith-dropdown
branch
2 times, most recently
from
August 7, 2024 20:04
55f7688
to
88d4f06
Compare
TSenter
requested changes
Aug 12, 2024
packages/ember-test-app/tests/integration/components/form/select-test.gts
Outdated
Show resolved
Hide resolved
packages/ember-test-app/tests/integration/components/form/select-test.gts
Outdated
Show resolved
Hide resolved
KeithClinard
force-pushed
the
keith-dropdown
branch
from
August 12, 2024 17:17
a04f5eb
to
124f5dd
Compare
KeithClinard
force-pushed
the
keith-dropdown
branch
from
August 12, 2024 17:17
124f5dd
to
23d4602
Compare
TSenter
requested changes
Aug 13, 2024
KeithClinard
force-pushed
the
keith-dropdown
branch
from
August 13, 2024 18:51
dbe5f45
to
3773cb4
Compare
TSenter
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really really like how the select works in the docs app. This is really cool!
TSenter
approved these changes
Aug 15, 2024
TSenter
added
internal
Internal changes or things that don't fit in any other category
enhancement
New feature or request
and removed
internal
Internal changes or things that don't fit in any other category
labels
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.