Update documentation to use symfony flex recipe #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docs to refer to the symfony recipe-contrib. Update references to yaml configs. Use env vars instead of parameters.yml. Update interfaces for autowiring.
|
Hey @ckrack! You did an awesome job! Thank you! I proofread it an made some small tweaks. Can you tell me if everything looks ok to you? Also, the entire Configuration section is actually automatically updated via this (ugly) script: https://github.com/knpuniversity/oauth2-client-bundle/blob/master/bin/update_readme Would you be interested in updating that script so that it generates the changes you made to the Configuration section (all the Cheers! |
|
Ping @ckrack! :) |
Use env vars (uppercase).
The Authenticatorinterface requires us to implement three methods, that were previously undocumented in the example. Fixes knpuniversity#108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs to refer to the symfony recipe-contrib.
Update references to yaml configs.
Use env vars instead of parameters.yml.
Update interfaces for autowiring.
Requested in #112