Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#133 drupal provider base url not configurable #135

Merged
merged 2 commits into from
Oct 15, 2018
Merged

Feature/#133 drupal provider base url not configurable #135

merged 2 commits into from
Oct 15, 2018

Conversation

mnugter
Copy link

@mnugter mnugter commented Oct 12, 2018

Adds base_url as a configurable property and update the README configuration example to reflect the option.

@mnugter mnugter mentioned this pull request Oct 12, 2018
Closed
@MolloKhan
Copy link
Contributor

Code looks good 👍

@weaverryan weaverryan merged commit b1f4107 into knpuniversity:master Oct 15, 2018
@weaverryan
Copy link
Member

Thank you @mnugter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnugter @MolloKhan @weaverryan