Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provider order (minor) #170

Merged
merged 2 commits into from
Apr 1, 2019
Merged

Conversation

umulmrum
Copy link
Contributor

Sorry, couldn't leave the list almost-sorted :-)

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @umulmrum

Thank you for this PR! However, we have a tool that helps to update README, you can clone the repo locally and run it with bin/update_readme in your console. Unfortunately, I see it shows a big diff with your current changes, so we can't merge it. If you think something is invalid after running bin/update_readme - it probably should be fixed in the bin/update_readme itself or in other places.

In short, you can run this bin/update_readme after you made some changes and make sure that there's no diff in the README and the repo is not in a dirty state.

Cheers!

@weaverryan
Copy link
Member

Yea, the fix here would be to update that script to make them alphabetical! I'm not sure why it's currently almost ordered :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@umulmrum
Copy link
Contributor Author

Ah I missed that - OK, changed.

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's perfect 👍

@weaverryan weaverryan merged commit f6743e2 into knpuniversity:master Apr 1, 2019
@weaverryan
Copy link
Member

Thank you @umulmrum!

@umulmrum umulmrum deleted the patch-1 branch April 1, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants