Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding parts of a client config #203

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

prudloff-insite
Copy link
Contributor

Assuming two different config files:

knpu_oauth2_client:
    clients:
        drupal:
            client_id: foo
            client_secret: foo
            type: drupal
            redirect_route: foo
            base_url: foo
imports:
    - { resource: config.yml }

knpu_oauth2_client:
    clients:
         drupal:
             client_id: bar

This will cause an InvalidConfigurationException:

Unrecognized option "0" under "knpu_oauth2_client/clients/drupal"

This PR fixes this error and allows overriding parts of the configuration.

(See symfony/symfony#12304 (comment) for a more detailed explanation.)

@weaverryan weaverryan merged commit 0a132ab into knpuniversity:master Oct 7, 2019
@weaverryan
Copy link
Member

Thank you @prudloff-insite!

@weaverryan
Copy link
Member

Tagged 1.29.2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants