Code

Phpstan fixes#204

Code

Merged

weaverryan merged 8 commits intoknpuniversity:masterknpuniversity/oauth2-client-bundle:masterfrom alister:phpstan-fixesCopy head branch name to clipboardOct 14, 2019

+186-115

Commits

Commits on Oct 5, 2019

• Max level for PHPStan, but ignore the DependencyInjection configuration

  Show description for 0b444ec
  alister

  committed
  0b444ec

  Copy full SHA for 0b444ec

• Prove $request->getSession() is a SessionInterface instance before use

  Show description for 2917a0e
  alister

  committed
  2917a0e

  Copy full SHA for 2917a0e

Commits on Oct 7, 2019

• Prove the type before returning a client from the container

  Show description for 61af3d7
  alister

  committed
  61af3d7

  Copy full SHA for 61af3d7

• Mark what is being returned & pretend it's more concrete in fetchUser

  Show description for c1909b5
  alister

  committed
  c1909b5

  Copy full SHA for c1909b5

• ProviderConfiguratorInterface indicates returning strings

  alister

  committed
  7b39397

  Copy full SHA for 7b39397

• Adding interface that must be extended for stronger type-checking

  alister

  committed
  bd75130

  Copy full SHA for bd75130

• Ignore the use of TreeBuilder::root(). Removed in 5.0, but used for <4.2 BC

  alister

  committed
  4f9d5f5

  Copy full SHA for 4f9d5f5

Commits on Oct 12, 2019

• getSession() without a session will throw an exception from v5.0

  Show description for aa68208
  alister

  committed
  aa68208

  Copy full SHA for aa68208