Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Buddy client #235

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Add Buddy client #235

merged 3 commits into from
Apr 17, 2020

Conversation

akondas
Copy link
Contributor

@akondas akondas commented Apr 2, 2020

  • Add Buddy client
  • fix static analysis

- php: 7.1
env: COMPOSER_FLAGS='--prefer-lowest --prefer-stable'

before_install:
- phpenv config-rm xdebug.ini || true
- composer self-update
- if [ "$DEPENDENCIES" = "dev" ]; then perl -pi -e 's/^}$/,"minimum-stability":"dev"}/' composer.json; fi;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see the sense of it, and it breaks the build, which in my opinion is much worse

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, fair enough - I'm not sure I feel super motivated to test and debug dev deps

@weaverryan weaverryan merged commit 4c36a34 into knpuniversity:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants