Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint to call supports in getCredentials method for symfony lower than 3.4 #97

Merged
merged 5 commits into from
Apr 20, 2018
Merged

Add hint to call supports in getCredentials method for symfony lower than 3.4 #97

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
697836b
add hint to call supports in getCredentials method for symfony <4
alexander-schranz Mar 29, 2018
5a966a2
update hint message for getCreentials to call supports for symfony <4
alexander-schranz Mar 29, 2018
613c7bd
update message for supports call lower than symfony 3.4 in getCredent…
alexander-schranz Mar 29, 2018
9191162
return null for typing in getCredentials symfony lower than 3.4 example
alexander-schranz Mar 30, 2018
5dccdd8
fix indention in symfony 3.4 example of getCredentials
alexander-schranz Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,11 @@ class MyFacebookAuthenticator extends SocialAuthenticator
{
// this method is only called if supports() returns true

// For Symfony lower than 3.4 the supports method need to be called manually here:
// if (!$this->supports($request)) {
// return null;
// }

return $this->fetchAccessToken($this->getFacebookClient());
}

Expand Down