Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable protobuf generation #69

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add option to disable protobuf generation #69

merged 1 commit into from
Nov 22, 2024

Conversation

saschagrunert
Copy link
Contributor

Refers to #67

Testing it in containerd/nri#121

@saschagrunert saschagrunert mentioned this pull request Nov 21, 2024
Merged
@saschagrunert saschagrunert changed the title Add option to disable pb gen Add option to disable protobuf generation Nov 21, 2024
@saschagrunert
Copy link
Contributor Author

containerd/nri#121 compiles now locally.

@saschagrunert
Copy link
Contributor Author

Can confirm it works for my local tests.

@saschagrunert
Copy link
Contributor Author

@knqyf263 PTAL

knqyf263
knqyf263 reviewed Nov 22, 2024
View reviewed changes
Copy link
Owner

@knqyf263 knqyf263 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you also update README? It should mention how to use go-plugin with protoc-gen-go with an example command.

@saschagrunert
Copy link
Contributor Author

Thanks for your contribution! Could you also update README? It should mention how to use go-plugin with protoc-gen-go with an example command.

Sure, I updated the README as suggested.

@saschagrunert
Add option to disable pb gen
d4b751c 
Signed-off-by: Sascha Grunert <[email protected]>
@knqyf263 knqyf263 merged commit d8d4205 into knqyf263:main Nov 22, 2024
4 checks passed
@knqyf263
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschagrunert @knqyf263