Fixes MAISTRA-1299: fix ASSERT failure and infinite loop when attempt…

…ing to unset readDisable state on a closed connection, part 2 (maistra#11)
knrc · Mar 26, 2020 · 13d2925 · 13d2925
1 parent a939c3c
commit 13d2925
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/source/common/network/connection_impl.cc b/source/common/network/connection_impl.cc
@@ -293,10 +293,6 @@ void ConnectionImpl::enableHalfClose(bool enabled) {
 void ConnectionImpl::readDisable(bool disable) {
   ASSERT(state() == State::Open);
   ASSERT(file_event_ != nullptr);
-  if (state() != State::Open || file_event_ == nullptr) {
-    // If readDisable is called on a closed connection in error, do not crash.
-    return;
-  }
 
   ENVOY_CONN_LOG(trace, "readDisable: enabled={} disable={} state={}", *this, read_enabled_,
                  disable, static_cast<int>(state()));