Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

probe-run depends on wasmparser #164

Closed
jonas-schievink opened this issue Feb 26, 2021 · 2 comments
Closed

probe-run depends on wasmparser #164

jonas-schievink opened this issue Feb 26, 2021 · 2 comments
Assignees
@Urhengulas
Labels
difficulty: easy Pretty easy to solve priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request

Comments

@jonas-schievink
Copy link
Contributor

It seems that we don't turn off enough features of the object crate, so it's pulling in a WASM parser. Since we'll never use that, we should remove the dependency.
@jonas-schievink jonas-schievink added type: enhancement Enhancement or feature request difficulty: easy Pretty easy to solve priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes labels Feb 26, 2021
@Urhengulas
Copy link
Member

The problem is, that probe-rs actually pulls in this dependency with all default features (see).

I've opened probe-rs/probe-rs#559 and asked them to hide the more specific features behind a feature flag.

@Urhengulas Urhengulas mentioned this issue Mar 11, 2021
Closed
2 tasks
@Urhengulas Urhengulas self-assigned this Mar 23, 2021
@Urhengulas
Copy link
Member

Fixed by #235

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Urhengulas Urhengulas

Labels
difficulty: easy Pretty easy to solve priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonas-schievink @Urhengulas