Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide specific features of object #559

Closed
Urhengulas opened this issue Feb 26, 2021 · 3 comments · Fixed by #580
Closed

Hide specific features of object #559

Urhengulas opened this issue Feb 26, 2021 · 3 comments · Fixed by #580
Assignees

Comments

@Urhengulas
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I'd like to decrease the dependency-chain of probe-run by not pulling in all dependencies of the default features of object, e.g. wasmparser in our case.

Describe the solution you'd like
I'd like probe-rs to hide the more niche features of object behind a feature flag. I am thinking of specific file support here.

Describe alternatives you've considered

Additional context

@Urhengulas
Copy link
Contributor Author

Hi @Yatekii, I am happy to do these changes, if you are generally interested in this. What do you think?

@Yatekii
Copy link
Member

Yatekii commented Mar 9, 2021

Hi @Urhengulas

I'll gladly accep a PR for this. I am not a dependency fanatic myself so I wont put my time into it, but a slimmer dependency count is a good thing :)

I do not even think that probe-rs needs a feature flag for this because we do not flash wasm.

I would like to have no feature flags at all. If we have those, we have the same issue that OpenOCD suffers from. A fragmented set of the same tool with very distinct featuresets.
The two flags we currently have are absolutely necessary unfortunately. ftdi because there is troubles with windows still and sentry because some folks are not okay with "tracking".

I hope that answers the question :) Ping me if not :)

@Urhengulas
Copy link
Contributor Author

Yes, I think I get your point. Will sit on it soon 😄

@bors bors bot closed this as completed in cead027 Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants