Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

snapshot test stack canary #223

Closed
japaric opened this issue Jun 4, 2021 · 0 comments · Fixed by #385
Closed

snapshot test stack canary #223

japaric opened this issue Jun 4, 2021 · 0 comments · Fixed by #385
Assignees
@Urhengulas
Labels
difficulty: medium Somewhat difficult to solve priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: test Feature or API needs tests

Comments

@japaric
Copy link
Member

japaric commented Jun 4, 2021 •
edited
Loading

as done in PR #218, we should add some snapshot tests that exercise the stack canary. This would mean not using flip-link and using enough stack -- without triggering an actual overflow -- to touch the stack canary.

cc @Lotterleben
@jonas-schievink jonas-schievink added difficulty: medium Somewhat difficult to solve type: test Feature or API needs tests labels Jun 4, 2021
@Urhengulas Urhengulas added priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes labels Jun 28, 2021
@Urhengulas Urhengulas self-assigned this Feb 21, 2023
@Urhengulas Urhengulas mentioned this issue Feb 23, 2023
Merged
@bors bors bot closed this as completed in 63bb9f3 Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Urhengulas Urhengulas

Labels
difficulty: medium Somewhat difficult to solve priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: test Feature or API needs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update snapshot tests and test stack canary knurling-rs/probe-run
3 participants
@jonas-schievink @japaric @Urhengulas