This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Update snapshot tests and test stack canary #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urhengulas
force-pushed
the
test-stack-canary
branch
2 times, most recently
from
0d29b4f to
d8bd18b
Compare
The change to `canary.rs` it to be able to detect the stack overflow.
Urhengulas
force-pushed
the
test-stack-canary
branch
from
d8bd18b to
792be23
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
overflow-no-flip-linkwhich triggers a stack overflow and does not have stack-overflow protection; thereforeprobe-runreports that data segments might be corruptedDepends on #383; only the last two commits are specific to this PR.
Fixes #223.