Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

probe-rs does not support passing configuration for "--chip-description-path" argument to underlying probe-rs #291

Closed
TomDeRybel opened this issue Dec 7, 2021 · 5 comments · Fixed by #301
Labels
difficulty: easy Pretty easy to solve priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request

Comments

@TomDeRybel
Copy link

TomDeRybel commented Dec 7, 2021

Describe the bug
I'm using parts in the STM32H735 family, which recently gained PAC and HAL support. Unfortunately these parts aren't supported by probe-rs yet (no yaml file entries for them in the crate). Thus, I used the procedure indicated by probe-rs to generate a local yaml from the pack file provided by ARM. This seems to all work fine using the probe-rs tools, such as cargo-flash, which support the use of the "--chip-description-path" argument.

To allow probe-run to do the same, I would need to be able to configure the path to this self-generated yaml, which currently does not seem supported.

Expected and observed behavior
I expect an argument to specify the path to the underlying probe-rs in .cargo/config, for instance:
runner = "probe-run --chip STM32H723VGTx --chip-description-path ../probe-rs_generated_packs/STM32H7_Series.yaml"

Operating System:
Linux

@jonas-schievink
Copy link
Contributor

This seems like something that would potentially be better solved with an environment variable that adds search paths for chip descriptions (that way the change applies across tools)

@TomDeRybel
Copy link
Author

An environment variable would work for me.
At this time, the probe-rs tools use different mechanisms themselves:

  • cargo-flash uses a command-line parameter
  • cargo-embed uses a definition file (Embed.toml)

@Urhengulas Urhengulas added difficulty: easy Pretty easy to solve priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request labels Dec 13, 2021
@bors bors bot closed this as completed in 7f7883d Feb 22, 2022
@TomDeRybel
Copy link
Author

Thank you for adding this feature!

@Urhengulas
Copy link
Member

Thank you for adding this feature!

You should thank @KOBA789 for implementing it! 👏🏾

@TomDeRybel
Copy link
Author

Thank you @KOBA789! This helps a lot with my own STM32H735 adventures 🍾

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
difficulty: easy Pretty easy to solve priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants