This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Add way to pass chip description file #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urhengulas
suggested changes
Feb 22, 2022
There was a problem hiding this comment.
Thank you for the PR @KOBA789!
When specifying the --chip-description-path, does a user still need to specify the --chip additionally? I don't ask what clap requires, but probe-rs.
Co-authored-by: Johann Hemmann <[email protected]>
Urhengulas
reviewed
Feb 22, 2022
Co-authored-by: Johann Hemmann <[email protected]>
|
Thank you for your review.
A chip description file may contain some variants. I think |
Makes sense, I just wanted to check with you. bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #291
I need the way to pass my own chip description file to probe-run because my target chip is a original soft processor core implemented on a FPGA.
There are other ideas on #291 but I wrote the simplest implementation for now.