This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
colorize defmt::assert_eq output #110
Merged
+98
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you mean |
src/logger.rs
Outdated
| } | ||
| Difference::Add(_) => continue, | ||
| Difference::Rem(s) => { | ||
| write!(buf, "{}", Colour::Red.on(Colour::Fixed(52)).bold().paint(s)).ok(); |
There was a problem hiding this comment.
Can you move the 52 to a constant?
src/logger.rs
Outdated
| write!( | ||
| buf, | ||
| "{}", | ||
| Colour::Green.on(Colour::Fixed(22)).bold().paint(s) |
yes. (in my mind, repr(C) (+ lots of care) is needed if you serialize C-like enums that you'd like to extend without breaking things. we are not binary (de)serializing the tags so non_exhaustive should suffice -- I was under the original impression that we did serialize them but was wrong) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this implementation parses a formatted log message and checks if the output corresponds to the
defmt::assert_eq!macro. If that's the case then it applies color using the same approach as thepretty-assertionscrate.a better implementation would be to tag the log messages from the
defmt::assert_eqand apply the coloring based on the tag, instead of re-parsing the formatted log message. however, that doesn't seem possible to implement in the v0.1.x line because:decoder::Tagthat would be a breaking change (UB?) because the enum is notrepr(C)SymbolTag::Customtag is present then old versiosn of probe-run will not print theassert_eqmessage (as they ignore custom tags)