This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
reject use of defmt and --no-flash (again) #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lotterleben
approved these changes
Jan 7, 2021
src/main.rs
Outdated
| @@ -399,6 +396,10 @@ fn notmain() -> Result<i32, anyhow::Error> { | |||
| .as_ref() | |||
| .map_or(false, |ch| ch.name() == Some("defmt")); | |||
|
|
|||
| if use_defmt && opts.no_flash { | |||
| bail!("\"defmt\" RTT channel is in use, but `--no-flash` was specified -- this combination is not allowed"); | |||
There was a problem hiding this comment.
nit: "defmt" RTT channel is in use requires system knowledge in order to grasp what the problem is– could this be rephrased to something like "attempting to specify --no-flashwhile using defmt -- this combination is not allowed"?
|
bors r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before PR #105 using defmt required the
--defmtflag. At that time it was not possible to use the--defmtand--no-flashflags together. The rationale for that restriction is that without itcargo runcan invokeprobe-runwith a newer version of the ELF different from the ELF that was last flashed on the device and that can result in log messages that make no sense and/or decoder errors.After PR 105 landed it unintentionally became possible to use defmt with --no-flash due to the auto-detection (auto-enable) mechanism. This PR corrects that and makes the use of
--no-flashflag and defmt an error again.