Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

WIP: probe-rs 0.11 update #215

Closed
wants to merge 2 commits into from
Closed

Conversation

Sheap
Copy link
Contributor

@Sheap Sheap commented May 27, 2021

In order to get probe-run working with the pre-production main branch of probe-rs, I had to make the following changes.

These changes appear to work, but I was just trying to quickly solve compiler issues, there may be better solutions, so I thought I'd open it up to the community.

@Urhengulas
Copy link
Member

Hi @Sheap, does this work for you locally, even though it fails in the CI?

@jonas-schievink
Copy link
Contributor

It just fails because probe-rs 0.11 has not yet been released to crates.io

@Urhengulas
Copy link
Member

It just fails because probe-rs 0.11 has not yet been released to crates.io

Ups, didn't check and assumed it uses git dependency 🙈

@Sheap
Copy link
Contributor Author

Sheap commented May 28, 2021

Locally I am using local versions of probe-rs and probe-rs-rtt both checked out on master, and probe-rs-rtt further modified to also use my local probe-rs. It works (for some definition of works: see here, but I don't believe that issue is probe-run related)

Using git dependencies didn't work because of conflicts between probe-rs and probe-rs-rtt.

@Urhengulas Urhengulas marked this pull request as draft June 23, 2021 14:09
@MathiasKoch
Copy link

Perhaps this could be revisited now that probe-rs 0.11.0 is released?
It would be nice to have the option of flash verification in probe-run.

bors bot added a commit that referenced this pull request Jun 29, 2021
235: Update to `probe-rs 0.11` r=Urhengulas a=Urhengulas

Based on #215.

Co-authored-by: Johann Hemmann <[email protected]>
@Urhengulas
Copy link
Member

Implemented in #235. Thank you @Sheap for caring about this!

@Urhengulas Urhengulas closed this Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants