Some clarifications and corrections #233
Conversation
Some clarifications and corrections having used probe-run for the first time. Hope that they make sense.
|
|
||
|
|
||
| ``` toml | ||
| [target.'cfg(all(target_arch = "arm", target_os = "none"))'] | ||
| runner = "probe-run --chip ${PROBE_RUN_CHIP}" |
There was a problem hiding this comment.
${PROBE_RUN_CHIP} is not just string to replace. It is environment variable.
There was a problem hiding this comment.
Yes. However, I felt that the env var approach was covered by the next few paragraphs. Also, the way it is now confused me - I actually thought that it represented some cargo related variable.
There was a problem hiding this comment.
I'd agree to keep the generic example, but would also be fine with additionally having a specific one. What do you think about moving the generic one down to where the env var approach is mentioned?
There was a problem hiding this comment.
Sure. Can you please make a suggestion and then I'll commit it. Thanks.
There was a problem hiding this comment.
Sadly, I can't, since github only allows me to make suggestions for lines you touched and the ones closely above and below. I will write my suggestion here in a moment.
There was a problem hiding this comment.
That's the whole section "1. Set the Cargo runner".
There was a problem hiding this comment.
I've deleted it here and added it as a suggestion for line 39, but is a change for the whole section.
|
|
||
|
|
||
| ``` toml | ||
| [target.'cfg(all(target_arch = "arm", target_os = "none"))'] | ||
| runner = "probe-run --chip ${PROBE_RUN_CHIP}" |
There was a problem hiding this comment.
I'd agree to keep the generic example, but would also be fine with additionally having a specific one. What do you think about moving the generic one down to where the env var approach is mentioned?
Co-authored-by: Johann Hemmann <[email protected]>
Co-authored-by: Johann Hemmann <[email protected]>
|
All changes are in |
Yes, only one fix: I guess we talked past each other for the last change. I added it as a suggestion for one line, but this isn't how it should be. It is a replacement for the whole section 1, but I wasn't able to suggest this, since github doesn't allow this. Can you therefore please remove everything after until the beginning of section 2? |
|
Okay, I was able to do it myself. Looks good now. |
|
bors r+ |
|
Great. Thanks. |
233: Some clarifications and corrections r=Urhengulas a=huntc Some clarifications and corrections having used probe-run for the first time. Hope that they make sense. Co-authored-by: Christopher Hunt <[email protected]> Co-authored-by: Johann Hemmann <[email protected]>
|
bors cancel |
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Some clarifications and corrections having used probe-run for the first time. Hope that they make sense.