This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Split "set rtt to blocking-mode" into function #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly this shortens the `fn start_program`, secondly it makes the "what" of this block of code more apparent.
Urhengulas
commented
Sep 8, 2021
Urhengulas
commented
Sep 8, 2021
Urhengulas
commented
Sep 8, 2021
|
bors r+ |
|
Build succeeded: |
This was referenced Sep 15, 2021
bors bot
added a commit
that referenced
this pull request
Sep 15, 2021
263: set blocking mode to 0b10 (BLOCK_IF_FULL) r=jonas-schievink a=japaric the previous version (after PR #257) was setting the blocking mode (first 2 bits of the flags field) to 0b11 (0b01 is what defmt-rtt uses by default) which is not a valid mode Co-authored-by: Jorge Aparicio <[email protected]>
bors bot
added a commit
to knurling-rs/defmt
that referenced
this pull request
Sep 15, 2021
579: defmt-rtt: fix check for blocking RTT r=japaric a=jonas-schievink This check wasn't testing correctly whether the `BLOCK_IF_FULL` bit was set, leading to knurling-rs/probe-run#257 breaking probe-run. Co-authored-by: Jonas Schievink <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly this shortens the
fn start_program,secondly it makes the "what" of this block of code more apparent.