This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Update snapshot tests #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that were done in #254
unsure why this changed; perhaps at some point the ELF was updated and the snapshot was not
|
this particular log statement is somewhat problematic (but not the end of the world): it prints the speed so it will make the snapshot test always fail (false positive). the snapshot test checks the output of probe-run when the |
|
CI failure is unrelated to this PR and should be fixed in PR #260 |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits for details
this makes
cargo test -- --ignored(includes snapshot tests) pass again