Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Turn demangling back on #280

Merged
merged 1 commit into from
Nov 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ version = "0.3.0"
addr2line = { version = "0.15", default-features = false, features = [
"fallible-iterator",
"std-object",
"rustc-demangle",
"cpp_demangle",
] }
anyhow = "1"
colored = "2"
Expand Down
13 changes: 11 additions & 2 deletions src/backtrace/symbolicate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,16 @@ impl Subroutine {
let demangled_name = frame
.function
.as_ref()
.and_then(|function| function.demangle().ok())
.and_then(|function| {
let demangled = function.demangle();
log::trace!(
"demangle {:?} (language={:X?}) -> {:?}",
function.raw_name(),
function.language,
demangled,
);
demangled.ok()
})
.map(|cow| cow.into_owned());

// XXX if there was inlining AND there's no function name info we'll report several
Expand Down Expand Up @@ -159,7 +168,7 @@ fn name_from_symtab(pc: u32, symtab: &SymbolMap<SymbolMapName>) -> Either<String

symtab
.get(address)
.map(|symbol| symbol.name().to_owned())
.map(|symbol| addr2line::demangle_auto(symbol.name().into(), None).into_owned())
.map(Either::Left)
.unwrap_or(Either::Right(pc))
}
Expand Down