This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Fix and refactor fn extract_stack_info
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The high end of the stack is always `initial_stack_pointer - 1`.
I am aware that in our concrete scenario we don't need all four, but only two conditions (as it was before), since we are checking `subset.contains(superset.end())` before. But I have added them for completeness.
…ss of the section
…st address of the section" This reverts commit fcb2b90.
|
@jonas-schievink The PR should be ready now. I tested it with the app-template and nrf52840-dk. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stack_rangeend.The high end of the stack is always
initial_stack_pointer - 1.fn is_supersetfor two ranges.I am aware that in our concrete scenario we don't need all four, but
only two conditions (as it was before), since we are checking
subset.contains(superset.end())before. But I have added them forcompleteness.
fn extract_stack_infodoesfn extract_stack_info