Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Add --no-flash option to probe-run #30

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

therealprof
Copy link
Contributor

Skipping the actual flashing process is useful if the binary to be run
is already in flash, either due being a re-run or use of a different
approach to do the flashing.

Signed-off-by: Daniel Egger [email protected]

Skipping the actual flashing process is useful if the binary to be run
is already in flash, either due being a re-run or use of a different
approach to do the flashing.

Signed-off-by: Daniel Egger <[email protected]>
@japaric
Copy link
Member

japaric commented Aug 24, 2020

I think that using --no-flash with --defmt would be error prone. There's currently no way to check whether the passed ELF and what was last flashed on the device match and if they don't match then all defmt messages would be detected as corrupted. So for now (*) I would like a CLI error to be thrown if one tries to use both flags.

(*) at least until we implement a mechanism to detect that what's flashed on the device matches the ELF we are going to use to decode the defmt data

@therealprof
Copy link
Contributor Author

I don't think it would be a lot more error prone than using without --defmt but I agree that it would be a lot better if we could get some feedback from cargo passed to the runner whether the implict cargo build modified the target or not. I looked around but couldn't find anything in the passed on environment about that.

I can make the two options mutual exclusive for now if you still prefer that.

Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@japaric japaric merged commit 7ce94c2 into knurling-rs:main Aug 25, 2020
@therealprof therealprof deleted the add-no-flash branch August 25, 2020 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants