Update to clap 4.0
#357
Update to clap 4.0
#357
Conversation
Urhengulas
requested review from
Dajamante
and removed request for
jonas-schievink
src/cli.rs
Outdated
| list_probes: bool, | ||
|
|
||
| /// The chip to program. | ||
| #[structopt(long, required_unless_one(&["list-chips", "list-probes", "version"]), env = "PROBE_RUN_CHIP")] | ||
| #[arg(long, required = true, conflicts_with_all = HELPER, env = "PROBE_RUN_CHIP")] |
There was a problem hiding this comment.
Not at all. It conflicts with --list-chips, --list_probes, --version. It seems I need a better name for HELPER.
There was a problem hiding this comment.
What do you think about HELPER_CMDS?
There was a problem hiding this comment.
Ah ok I see it now when comparing again with structopt. Those three conflict : list-chips, list-probes, version.
| _rest: Vec<String>, | ||
| } | ||
|
|
||
| /// Helper commands, which will not execute probe-run normally. |
There was a problem hiding this comment.
So you can pass probe-run HELPER?
I don't get it from the documentation.
There was a problem hiding this comment.
No. HELPER is just a helper variable to not have ["list_chips", "list_probes", "version"] twice. What could be a better name?
There was a problem hiding this comment.
I think HELPER_CMD is good! I think I got confused because I expected to see <HELPER_CMD>, to recognize it immediately as an argument. But that's just me.
I was thinking about that as well. The reasoning of the authors of clap is that they want to give the cli authors (us) control over the order. We can just solve this by alphabetically ordering the args. |
|
bors r=Dajamante |
|
Build succeeded: |
| _rest: Vec<String>, | ||
| } | ||
|
|
||
| /// Helper commands, which will not execute probe-run normally. |
There was a problem hiding this comment.
I think HELPER_CMD is good! I think I got confused because I expected to see <HELPER_CMD>, to recognize it immediately as an argument. But that's just me.
Afaik it is convention to commit the lock file for applications, but not for libraries.
That would be possible. |
This PR updates our cli parser
clapfrom2.34to4.0.The end-user experience should stay similar, but has a fresh UI, many internal improvements, and better help messages when a user gets the arguments wrong.
On the left you can see the new UI, and on the right the old.
