Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encode redirect url if not already encoded #1384

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Sep 27, 2019

Same bug from express expressjs/express@76eaa32

@fengmk2
Copy link
Member Author

fengmk2 commented Sep 27, 2019

cc @dougwilson

@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #1384 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1384   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           4       4           
  Lines         379     380    +1     
======================================
+ Hits          379     380    +1
Impacted Files Coverage Δ
lib/response.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 817b498...6fcf1d4. Read the comment docs.

@dougwilson
Copy link
Contributor

LGTM

@fengmk2 fengmk2 merged commit 54e8fab into master Sep 28, 2019
@fengmk2
Copy link
Member Author

fengmk2 commented Sep 28, 2019

2.8.2

@fengmk2 fengmk2 deleted the fix-not-encoded-url-redirect branch September 28, 2019 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants