Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Coverage Improved #64

Closed
wants to merge 1 commit into from
Closed

Test Coverage Improved #64

wants to merge 1 commit into from

Conversation

JacobMGEvans
Copy link
Contributor

@JacobMGEvans JacobMGEvans commented Mar 14, 2020 •
edited
Loading

  • The layer has been increased to all 100's coverage
  • The router has had an additional logic control flow line covered reducing uncovered lines from 4 to 3
  • Rebase SUCCESS! 🎉🎊funny enough my Prettier added a CRLF line to a file
    @niftylettuce

Screen Shot 2020-03-11 at 9 34 24 PM

@JacobMGEvans JacobMGEvans force-pushed the rebase-to-upstream branch 2 times, most recently from c01d867 to d27d89f Compare March 14, 2020 14:25
@JacobMGEvans
Copy link
Contributor Author

JacobMGEvans commented Mar 14, 2020 •
edited
Loading

@niftylettuce Since I don't have the option to squash the PR I did it manually and created this new PR
I'll try to keep the forked branches up to date with the upstream master, doing stuff like this a little new to me for lol

@JacobMGEvans
Rebase w/ Test Coverage + Squashed Upstream Master
30b9437 
* Environment set and dynamic

* Removed local setting file added by mistake

* Benchmarks now working with dynamic environment variables make file pass in FACTOR and USE_MIDDLEWARE

* Removing messages I had added because the output looked cluttered
- Improving the output could be helpful
- Kept the order in the makefile

* clarify the number output meaning

* Travis Node versions updated

* More Versions in Travis Build

Environment set and dynamic

Removed local setting file added by mistake

Benchmarks now working with dynamic environment variables make file pass in FACTOR and USE_MIDDLEWARE

Removing messages I had added because the output looked cluttered
- Improving the output could be helpful
- Kept the order in the makefile

clarify the number output meaning

Covered Line 456 else if (allowedArr.length)

Covered last line uncovered 216 in Layer.js
@niftylettuce
Copy link
Contributor

Any chance you could update this one more before I merge it @JacobMGEvans ?

@JacobMGEvans
Copy link
Contributor Author

Hmm, seems to be a lot of changes since this PR. Are most of the tests currently passing in your master branch?

@JacobMGEvans
Copy link
Contributor Author

I think Travis needs to have a Test check for PR's??

@JacobMGEvans
Copy link
Contributor Author

JacobMGEvans commented Apr 28, 2020 •
edited
Loading

Currently if I pull in remote(upstream) master into my master and run the tests I get this. Thats resolving the merge conflict with accepting incoming changes ("theirs").
Screen Shot 2020-04-27 at 8 51 56 PM
Screen Shot 2020-04-27 at 8 52 32 PM

@3imed-jaberi
Copy link
Member

@JacobMGEvans, thank u for your PR.
I'm going to work on this.

3imed-jaberi added a commit to 3imed-jaberi/koa-router that referenced this pull request May 29, 2020
@3imed-jaberi
clean test + fix koajs#64 🧪..
83b753a
@3imed-jaberi 3imed-jaberi mentioned this pull request May 29, 2020
Merged
@niftylettuce
Copy link
Contributor

v9.0.1 released https://github.com/koajs/router/releases/tag/v9.0.1

@JacobMGEvans JacobMGEvans deleted the rebase-to-upstream branch May 30, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacobMGEvans @niftylettuce @3imed-jaberi