improvement: better debug at the end of Router#register #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and not Layer#constructor when Router#register can still act upon the route (Layer) after having debugged it
|
@Sinewyk can you update your PR to resolve conflicts? once done I will merge and publish this to npm and GitHub |
|
v9.3.1 released to npm and GitHub with this, thank you @Sinewyk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and not Layer#constructor when Router#register can still act upon
the route (Layer) after having debugged it
for the debug to be correct when debugging the special case prefix + '/' because the previous debug happened before the setPrefix call that did the trick