feat: support SWR v2 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I've fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs. https://github.com/vercel/swr/releases/tag/2.0.0-beta.0
SWR v2 has changed the internal structure of the cache data, so DevTools has to support the new data structure.
SWR DevTools has 3 packages, which are
swr-devtools,swr-devtools-panel, andswr-devtools-extensions.swr-devtoolsis a package that developers install and put it into their applicationswr-devtools-panelis a package used in a browser extension panelswr-devtools-extensionsis a package to be run as a background scriptswr-devtoolsis installed by application developers, so this doesn't have to deal with either SWR v1 or v2.swr-devtools-panelandswr-devtools-extensionsare installed from store of extensions, so developers always have to use the latest version. It means thatswr-devtools-panelandswr-devtools-extensionshave to support SWR v1 and v2.My strategy is the following.
[ ] 1.swr-devtoolsconverts the cache data from SWR v1 format to v2 and sends the data[ ] 2.swr-devtools-panelandswr-devtools-extensionssupport SWR v2 format[ ] 3.swr-devtoolssupports SWR v2 in the next major versionI've added v1 and v2 support into
swr-devtools-panelbecause I think it's a minimum way to achieve this.