fix: swap '_' for leading or trailing apostrophes in worksheet names #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make xls exports more excel-compatible - fix failing export when form names start or end with apostrophe
jnm
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Fixes "export failed" when trying to export forms whose name starts or ends with an apostrophe
💭 Notes
Make xls worksheet names more Excel-compatible, by replacing leading or trailing apostrophes with underscores.
Add tests for similar modifications we already do:
Fixes an export failing in kpi.
Internal discussion: "Apostrophe at the end of the title breaks data downloading."