-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: next version #77
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
===========================================
+ Coverage 38.19% 94.89% +56.69%
===========================================
Files 7 2 -5
Lines 233 235 +2
Branches 52 65 +13
===========================================
+ Hits 89 223 +134
+ Misses 132 11 -121
+ Partials 12 1 -11
Continue to review full report at Codecov.
|
fixes #79 |
Nice! Let's get er done :) This is one of the last things I'm waiting on to take https://classroom.qvault.io out of the sandbox |
@koca is there an ETA for when this will be merged/released? |
Hey @MattIPv4! Tomorrow i'll try to release a new version. |
Hi guys! Released a beta version of v1 🎉 Try now: There are breaking changes so please read the readme in https://github.com/koca/vue-prism-editor/tree/feature/next cc @MattIPv4 @lane-c-wagner @elevatebart btw next version is just 2.7kb gzip 🚀 (previously ~7-9kb gzip) |
example codesandbox using the next version: https://codesandbox.io/s/vue-prism-editor-next-gzi7k |
Hey @koca, I'm having a lot of selector power issues (existing styling framework is overriding your textarea styles). Could I suggest writing the styling in scss, so that you can more easily nest the selectors to give them more power (and so I can import the styles directly in our scss at the right point to give them even more power)? Something like: https://gist.github.com/MattIPv4/3939e6c7079866260181d88864fa5561 |
Looks great @koca ! Thanks for working on this. If you want to see what we are building with your library check it out: https://classroom.qvault.io |
So you are having a css spesificity issue on textarea, interesting 🤔. Thanks for the info!
I'm not sure about supporting scss but we can do nesting with postcss to fix the spesificity. You can still import |
Love it! Just checked the js course looks promising ✌️ Where do you run the code client/backend? |
@koca The Go code runs using web assembly, and the JavaScript is executed right in the browser |
Running go code on the browser using web assembly? 🚀 Cool! Is it open source? |
Yeah here is a tutorial: https://qvault.io/2020/07/01/running-go-in-the-browser-with-web-assembly-wasm/ You can also hop in our discord if you want to stay in the loop https://qvault.io |
@koca What are we waiting for on this version? |
@koca I love this library, but I'm really needing that spacing change! Is there anything I can do to help get this next release out? |
@lane-c-wagner been busy sorry 🙏. Actually i was waiting for feedbacks but seems like other guys are busy as well :D anyway just released official v1 release 🎉. Enjoy and thanks for the love mate |
Thank you, I will update my CMS to use the latest version! Keep up the great work! I'll let you know how it works, when I get around to do this. |
@koca Thanks so much! New "Practical Cryptography" and "Go Mastery" courses are going to be so much better now :) https://classroom.qvault.io Also, be sure to update the NPM registry when you have the chance! |
@lane-c-wagner classroom.qvault.io so good 🚀 cant try the courses(need to pay) but tried the free one(more than last time ^^) and love the clean design! 🚀 btw vue-prism-editor code and version is correct on NPM, seems like i just need to update the readme. Maybe i can't see, can you tell me what is missing? |
I got it working, I was just confused about NPM. My bad! If you want to check out another course or two use this code to get some free gems: |
@koca, you rock my socks... In other words, it works and vue-live is now awesome ! Thank you ;) |
haha thanks @elevatebart! We use |
Next version of vue-prism-editor
New features
Fixes
9kb to ~3kb gz