Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: next version #77

Merged
merged 23 commits into from
Aug 8, 2020
Merged

feat: next version #77

merged 23 commits into from
Aug 8, 2020

Conversation

koca
Copy link
Owner

@koca koca commented Jun 20, 2020

Next version of vue-prism-editor

New features
Fixes
9kb to ~3kb gz

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2020

Codecov Report

Merging #77 into master will increase coverage by 56.69%.
The diff coverage is 94.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #77       +/-   ##
===========================================
+ Coverage   38.19%   94.89%   +56.69%     
===========================================
  Files           7        2        -5     
  Lines         233      235        +2     
  Branches       52       65       +13     
===========================================
+ Hits           89      223      +134     
+ Misses        132       11      -121     
+ Partials       12        1       -11     
Impacted Files Coverage Δ
packages/vue-prism-editor/src/Editor.ts 94.87% <94.87%> (ø)
packages/vue-prism-editor/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b1fdd...f21f84a. Read the comment docs.

@koca
Copy link
Owner Author

koca commented Jun 21, 2020

Fixes:
#71 custom higlight fn
#49 fixed
#73 fixed
#72 fixed
#43 fixed
#70 fixed
#62 #65 fixed
#67 custom higlight fn
#41 fixed
#28 fixed

@koca
Copy link
Owner Author

koca commented Jun 25, 2020

fixes #79

@wagslane
Copy link
Contributor

Nice! Let's get er done :) This is one of the last things I'm waiting on to take https://classroom.qvault.io out of the sandbox

@MattIPv4
Copy link

@koca is there an ETA for when this will be merged/released?

@koca
Copy link
Owner Author

koca commented Jul 10, 2020

Hey @MattIPv4! Tomorrow i'll try to release a new version.
cc @lane-c-wagner

@koca
Copy link
Owner Author

koca commented Jul 11, 2020

Hi guys! Released a beta version of v1 🎉

Try now: [email protected]

There are breaking changes so please read the readme in https://github.com/koca/vue-prism-editor/tree/feature/next

cc @MattIPv4 @lane-c-wagner @elevatebart
If you need help or have ideas just let me know 😊

btw next version is just 2.7kb gzip 🚀 (previously ~7-9kb gzip)
editorv1-size

@koca
Copy link
Owner Author

koca commented Jul 11, 2020

example codesandbox using the next version: https://codesandbox.io/s/vue-prism-editor-next-gzi7k

@MattIPv4
Copy link

MattIPv4 commented Jul 13, 2020

Hey @koca,

I'm having a lot of selector power issues (existing styling framework is overriding your textarea styles).

Could I suggest writing the styling in scss, so that you can more easily nest the selectors to give them more power (and so I can import the styles directly in our scss at the right point to give them even more power)?

Something like: https://gist.github.com/MattIPv4/3939e6c7079866260181d88864fa5561

@wagslane
Copy link
Contributor

Looks great @koca ! Thanks for working on this. If you want to see what we are building with your library check it out: https://classroom.qvault.io
Or the playground:
https://classroom.qvault.io/playground/go

@koca
Copy link
Owner Author

koca commented Jul 13, 2020

Hey @koca,

I'm having a lot of selector power issues (existing styling framework is overriding your textarea styles).

So you are having a css spesificity issue on textarea, interesting 🤔. Thanks for the info!

Could I suggest writing the styling in scss, so that you can more easily nest the selectors to give them more power (and so I can import the styles directly in our scss at the right point to give them even more power)?

Something like: https://gist.github.com/MattIPv4/3939e6c7079866260181d88864fa5561

I'm not sure about supporting scss but we can do nesting with postcss to fix the spesificity. You can still import css in scss so that would work. Thank you! 😊

@koca
Copy link
Owner Author

koca commented Jul 13, 2020

Looks great @koca ! Thanks for working on this. If you want to see what we are building with your library check it out: https://classroom.qvault.io
Or the playground:
https://classroom.qvault.io/playground/go

Love it! Just checked the js course looks promising ✌️ Where do you run the code client/backend?

@wagslane
Copy link
Contributor

@koca The Go code runs using web assembly, and the JavaScript is executed right in the browser

@koca
Copy link
Owner Author

koca commented Jul 13, 2020

@koca The Go code runs using web assembly, and the JavaScript is executed right in the browser

Running go code on the browser using web assembly? 🚀 Cool! Is it open source?

@wagslane
Copy link
Contributor

Yeah here is a tutorial: https://qvault.io/2020/07/01/running-go-in-the-browser-with-web-assembly-wasm/

You can also hop in our discord if you want to stay in the loop https://qvault.io

@wagslane
Copy link
Contributor

@koca What are we waiting for on this version?

@wagslane
Copy link
Contributor

wagslane commented Aug 7, 2020

@koca I love this library, but I'm really needing that spacing change! Is there anything I can do to help get this next release out?

@koca koca merged commit f21f84a into master Aug 8, 2020
@koca
Copy link
Owner Author

koca commented Aug 8, 2020

@lane-c-wagner been busy sorry 🙏. Actually i was waiting for feedbacks but seems like other guys are busy as well :D anyway just released official v1 release 🎉. Enjoy and thanks for the love mate ♥️ 👍
Please let me know if you need any help.

@nikocraft
Copy link

Thank you, I will update my CMS to use the latest version! Keep up the great work! I'll let you know how it works, when I get around to do this.

@wagslane
Copy link
Contributor

wagslane commented Aug 8, 2020

@koca Thanks so much! New "Practical Cryptography" and "Go Mastery" courses are going to be so much better now :) https://classroom.qvault.io

Also, be sure to update the NPM registry when you have the chance!

@koca
Copy link
Owner Author

koca commented Aug 8, 2020

@lane-c-wagner classroom.qvault.io so good 🚀 cant try the courses(need to pay) but tried the free one(more than last time ^^) and love the clean design! 🚀

btw vue-prism-editor code and version is correct on NPM, seems like i just need to update the readme. Maybe i can't see, can you tell me what is missing?

@wagslane
Copy link
Contributor

wagslane commented Aug 8, 2020

I got it working, I was just confused about NPM. My bad!

If you want to check out another course or two use this code to get some free gems: 3CORBL @koca Thanks for the awesome library

@elevatebart
Copy link
Contributor

@koca, you rock my socks... In other words, it works and vue-live is now awesome ! Thank you ;)

@koca
Copy link
Owner Author

koca commented Aug 9, 2020

haha thanks @elevatebart! We use vue-live in @chakra-ui it works great 👍
cheers @lane-c-wagner! and thank you for the coupon 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants