Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issues on the Drops page #7857

Closed
1 task done
jsidorenko opened this issue Oct 27, 2023 · 4 comments
Closed
1 task done

Minor issues on the Drops page #7857

jsidorenko opened this issue Oct 27, 2023 · 4 comments
Labels
A-drop-page issues related to drop page bug Something isn't working p2 core functionality, or is affecting 60% of app

Comments

@jsidorenko
Copy link

jsidorenko commented Oct 27, 2023

What happened?

I've noticed a couple of minor issues on the Drops page:

  1. The X button doesn't work
image



2. should be "unlockable" (one word, no dashes)
image



3. Just an idea: When all the items are named the same, and the image is the same, maybe it's better to add the item's id to the title?
image

Please reproduce in steps

https://kodadot.xyz/ahk/drops/chained

Expected Behavior

What browsers are you seeing the problem on?

Chrome

At which address did you encounter bug?

kodadot.xyz

Are you logged in?

Yes

Which wallet you are using?

No response

Screenshots

See the main description

Relevant log output

No response

Payment link for reward

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jsidorenko jsidorenko added bug Something isn't working p2 core functionality, or is affecting 60% of app labels Oct 27, 2023
@kodabot
Copy link
Collaborator

kodabot commented Oct 28, 2023

ASSIGNED - @shengxinjing 🔒 LOCKED -> Sunday, October 29th 2023, 05:12:38 UTC -> 24 hours

@yangwao
Copy link
Member

yangwao commented Oct 28, 2023

  1. Just an idea: When all the items are named the same, and the image is the same, maybe it's better to add the item's id to the title?

@yangwao yangwao added the A-drop-page issues related to drop page label Oct 28, 2023
@kodabot
Copy link
Collaborator

kodabot commented Oct 29, 2023

ASSIGNMENT EXPIRED - @shengxinjing has been unassigned.

github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2023
fix: Drops page model close button #7857
@daiagi daiagi mentioned this issue Dec 22, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-drop-page issues related to drop page bug Something isn't working p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

No branches or pull requests

4 participants
@jsidorenko @yangwao @kodabot and others