Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5060 min offer 0.01 #5065

Merged
merged 8 commits into from
Feb 26, 2023
Merged

Conversation

maderi21
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image
image

@maderi21 maderi21 requested a review from a team as a code owner February 20, 2023 21:48
@maderi21 maderi21 requested review from preschian and Jarsen136 and removed request for a team February 20, 2023 21:48
@kodabot
Copy link
Collaborator

kodabot commented Feb 20, 2023

SUCCESS @maderi21 PR for issue #5060 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit d8487c0
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63fb48c0eff0c80008788a2d
😎 Deploy Preview https://deploy-preview-5065--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Feb 22, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm, later on we might want to change MIN_OFFER_PRICE to be chain specific

@vikiival
Copy link
Member

pay 29 usd

@yangwao
Copy link
Member

yangwao commented Feb 26, 2023

😍 Perfect, I’ve sent the payout
💵 $29 @ 38.9 USD/KSM ~ 0.746 $KSM
🧗 JHJGu2aWyAFBfcso8bR7ma82p15YAavyN6vQfJyWuhniNGa
🔗 0x561e0fdf6b0d4792ea0c3b9100e33e6a01b3aaa9d87485be2647ec1f9ee4e090

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 26, 2023
@codeclimate
Copy link

codeclimate bot commented Feb 26, 2023

Code Climate has analyzed commit d8487c0 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival enabled auto-merge February 26, 2023 11:59
@vikiival vikiival merged commit 1a6752c into kodadot:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer too low
8 participants