Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ transaction execBuy #5150

Merged
merged 4 commits into from
Mar 3, 2023
Merged

✨ transaction execBuy #5150

merged 4 commits into from
Mar 3, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Mar 2, 2023 •
edited
Loading

This feature will handle BUY tx from one single point

PR Type

  • Feature
  • Refactoring

Context

Optional

  • I've tested it at /snek/gallery/659233203-5

side note

  • LIST 0.0010
  • BUY 0.0009
  • ???

@roiLeo roiLeo requested a review from a team as a code owner March 2, 2023 09:59
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team March 2, 2023 09:59
@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 581726b
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6401d4fd010c6d00081b28b5
😎 Deploy Preview https://deploy-preview-5150--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo roiLeo requested a review from vikiival March 2, 2023 10:00
This was referenced Mar 2, 2023
Closed
Closed
daiagi
daiagi reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small stuff
overall code lgtm

@vikiival
Copy link
Member

vikiival commented Mar 3, 2023

@roiLeo what does the side note mean?

@roiLeo
Copy link
Contributor Author

roiLeo commented Mar 3, 2023

@roiLeo what does the side note mean?

On my test /snek/gallery/659233203-5
Capture d’écran 2023-03-03 à 11 51 55 AM

This is weird, there is a difference between LIST price and BUY price

@vikiival
Copy link
Member

vikiival commented Mar 3, 2023

Tested on

https://deploy-preview-5150--koda-nuxt.netlify.app/rmrk/gallery/9290733-94ae5001bac3833457-PNPRT-NFT_PINUP_GIRL_006-0000000000000005

WFM

I can't sadly buy any nfts on snek, some balance issue

@vikiival
Copy link
Member

vikiival commented Mar 3, 2023

@roiLeo because royalty was calculated

^-^

@vikiival
Copy link
Member

vikiival commented Mar 3, 2023

pay 44 usd

@codeclimate
Copy link

codeclimate bot commented Mar 3, 2023

Code Climate has analyzed commit 581726b and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 6d299ff into kodadot:main Mar 3, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Mar 3, 2023

I can't sadly buy any nfts on snek, some balance issue

do you mind sharing what happened? we already fixed some issue on balance

@roiLeo roiLeo deleted the feature/transaction/execBuyTx branch March 3, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian left review comments

@vikiival vikiival vikiival approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

composable transaction transactionBuy
4 participants
@roiLeo @vikiival @preschian @daiagi