Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No properties displayed #5382

Merged
merged 3 commits into from
Mar 28, 2023
Merged

fix: No properties displayed #5382

merged 3 commits into from
Mar 28, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Mar 26, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner March 26, 2023 07:20
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team March 26, 2023 07:20
@kodabot
Copy link
Collaborator

kodabot commented Mar 26, 2023

SUCCESS @Jarsen136 PR for issue #5368 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Mar 26, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 8706d4a
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6422e651acf4010007668434
😎 Deploy Preview https://deploy-preview-5382--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136 Jarsen136 requested a review from roiLeo March 27, 2023 16:43
@codeclimate
Copy link

codeclimate bot commented Mar 28, 2023

Code Climate has analyzed commit 8706d4a and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@vikiival vikiival merged commit 67ab0c9 into kodadot:main Mar 28, 2023
@vikiival
Copy link
Member

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Mar 28, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Mar 28, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 32.46 USD/KSM ~ 0.616 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xc9fbf52a23ca0544a982aff4e6dba36e33ee01105d24f4f57b490f6082590502

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 28, 2023
@yangwao yangwao removed the paid pull-request has been paid label Aug 8, 2023
@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5 USD/DOT ~ 4 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x4d05c7d042218502ddf5ddfad720cc568ef8303e5eae7d0a47443919864afef3

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No properties displayed
6 participants