#7685 replace placeholders #7698

prachi00 · 2023-10-17T04:00:23Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Needs QA check

@kodadot/qa-guild please review

Context

Closes Replace gallery item place holder with koda v4 logo #7685
Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

My DOT address: Payout

Screenshot 📸

My fix has changed UI

Copilot Summary

kodabot · 2023-10-17T04:00:27Z

SUCCESS @prachi00 PR for issue #7685 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

reviewpad · 2023-10-17T04:00:50Z

AI-Generated Summary: This pull request updates the placeholders images used depending on the theme mode in the useTheme.ts file. Instead of using /placeholder.webp for dark mode and /placeholder-white.webp for light mode, it now uses /Kdark.svg and /Klight.svg respectively. These SVG files, Kdark.svg and Klight.svg, added to the public directory, define several complex shapes through various <path> elements. It's worth noting that some paths are filled with black color, and others are filled with white, denoted by different SVG rules like fill-rule and clip-rule.

netlify · 2023-10-17T04:02:27Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`5c6ed3e`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/65409255378c520008577743
😎 Deploy Preview	https://deploy-preview-7698--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

roiLeo

could you use minimized .webp instead?

prachi00 · 2023-10-18T03:50:32Z

could you use minimized .webp instead?

I converted online, the quality is reduced though

@exezbcz can you provide webp?

exezbcz · 2023-10-18T17:06:35Z

@prachi00 Hope this helps. I decided to make it k-grey for both modes, since its placeholder, it does not have to have big contrast

could you also make it smaller, something like with the size of container

ZIP

here is zip, both dark and light version with 4 quality versions - levels of compression.
kdarkplaceholder.zip
klightplaceholder.zip

prachi00 · 2023-10-19T04:48:02Z

@exezbcz check now

prury · 2023-10-19T15:08:28Z

@exezbcz i think placeholder when loading collection logo image could also be reduced, wdyt
on canary it also had some margins around)

exezbcz · 2023-10-20T16:29:25Z

weird, still see the old one on explorer

exezbcz · 2023-10-20T16:31:05Z

@prury yup, smaller please and without the stretch

prachi00 · 2023-10-21T23:37:09Z

weird, still see the old one on explorer

where is this? dont we have skeletons in explore now?

prachi00 · 2023-10-21T23:38:40Z

@prury

prury · 2023-10-22T02:12:38Z

@prury

@prachi00 the image you attached still shows the old logo. I believe its supposed to show the new logo, but using the same margins and image proportions that we have on canary

prachi00 · 2023-10-22T22:59:34Z

@prury

prachi00 · 2023-10-24T04:13:42Z

it seems the old placeholder is coming from `nftListWithSearch` query @roiLeo @prury can we add this in a separate issue ?

roiLeo · 2023-10-24T06:31:54Z

it seems the old placeholder is coming from nftListWithSearch query @roiLeo @prury can we add this in a separate issue ?

it's comming from IPFS_KODADOT_IMAGE_PLACEHOLDER

prachi00 · 2023-10-25T01:32:40Z

IPFS_KODADOT_IMAGE_PLACEHOLDER

okay so what should be the value now for this? how do I get that ipfs hash thingy for new logo?

prachi00 · 2023-10-26T02:47:38Z

IPFS_KODADOT_IMAGE_PLACEHOLDER

okay so what should be the value now for this? how do I get that ipfs hash thingy for new logo?

@roiLeo would you know?

daiagi · 2023-10-26T06:01:11Z

okay so what should be the value now for this? how do I get that ipfs hash thingy for new logo?

maybe I am wrong and we have another way but my guess would be

download IPFS desktop
upload the new image file from your computer
use the new identifier in the code

https://docs.ipfs.tech/how-to/desktop-app/

roiLeo · 2023-10-26T06:44:04Z

okay so what should be the value now for this? how do I get that ipfs hash thingy for new logo?

Mint it!

prachi00 · 2023-10-27T03:14:03Z

IPFS_KODADOT_IMAGE_PLACEHOLDER

would you mind generating one? I am having trouble loading it
I got this QmVFb2qxyFePqzMqMrwcszpavi95FUhwapPVPu3z7Fxf1B hash but it doesn't load

https://image-beta.w.kodadot.xyz/ipfs/QmVFb2qxyFePqzMqMrwcszpavi95FUhwapPVPu3z7Fxf1B

prachi00 · 2023-10-29T22:37:12Z

IPFS_KODADOT_IMAGE_PLACEHOLDER

would you mind generating one? I am having trouble loading it I got this QmVFb2qxyFePqzMqMrwcszpavi95FUhwapPVPu3z7Fxf1B hash but it doesn't load

https://image-beta.w.kodadot.xyz/ipfs/QmVFb2qxyFePqzMqMrwcszpavi95FUhwapPVPu3z7Fxf1B

@roiLeo @daiagi

daiagi · 2023-10-29T23:53:50Z

Which network did you mint it in?
I didn't find it browsing through explore

prachi00 · 2023-10-30T17:01:04Z

Which network did you mint it in? I didn't find it browsing through explore

I did it through the ipfs thing you mentioned

daiagi · 2023-10-31T02:59:30Z

Roileo advice was better. Mint it

prachi00 · 2023-10-31T04:02:58Z

Roileo advice was better. Mint it

yeah so about that, I dont have any balance for testing stuff, and I don't know how to get tokens since we shifted on telegram from discord, would you be able to mint it? or tell me how I can get some test tokens? @daiagi

daiagi · 2023-10-31T05:05:42Z

there you go:
https://kodadot.xyz/ahk/collection/197

https://image.w.kodadot.xyz/ipfs/bafkreiddaramgs4jvneno4pkjhrs4lr3dbxmrgpqqtviwhco674qeu4vx4
https://image.w.kodadot.xyz/ipfs/bafkreigbvowevtdh5ktnr5kyfxf2b56lp4424zj2gb6wona6if4lh35mbe

prachi00 · 2023-10-31T05:29:05Z

there you go: https://kodadot.xyz/ahk/collection/197

https://image.w.kodadot.xyz/ipfs/bafkreiddaramgs4jvneno4pkjhrs4lr3dbxmrgpqqtviwhco674qeu4vx4 https://image.w.kodadot.xyz/ipfs/bafkreigbvowevtdh5ktnr5kyfxf2b56lp4424zj2gb6wona6if4lh35mbe

thank you

what is the equivalent for the drip thing on telegram?

codeclimate · 2023-10-31T05:36:48Z

Code Climate has analyzed commit 5c6ed3e and detected 0 issues on this pull request.

View more on Code Climate.

sonarqubecloud · 2023-10-31T05:37:16Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.9% Duplication

prachi00 · 2023-10-31T06:58:33Z

@roiLeo @daiagi it seems even after replacing the hash
https://deploy-preview-7698--koda-canary.netlify.app/ksm/explore/items?listed=true&search=bureau
still has the old placeholder with hash bafkreifahjdjerrz65puqznmsu2acoktrxjbo3vvp2f2j4eb7h5tc345fi
I searched the codebase and we don't have it anywhere else

daiagi · 2023-10-31T07:14:21Z

It seems that IPFS_KODADOT_IMAGE_PLACEHOLDER is only used while minting
so any nft minted before this PR will show the previous placeholder

it looks like we're just going to have to live with it

yangwao · 2023-11-01T11:18:45Z

Thanks!
pay 30 usd

yangwao · 2023-11-01T11:18:57Z

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.35 USD/DOT ~ 6.897 $DOT
🧗 13Qx65nLd6SwdtjrRyuoEtp9CKXhF651xdHBPaXcvhwKm4N1
🔗 0x932790f73fcd5119aa0cef35a9e75b0d781f35b46b02af0231721cedb9a2cf23

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

kodadot#7685 replace placeholders

ff34e80

prachi00 requested a review from a team as a code owner October 17, 2023 04:00

prachi00 requested review from floyd-li and daiagi and removed request for a team October 17, 2023 04:00

reviewpad bot added small Pull request is small waiting-for-review labels Oct 17, 2023

roiLeo reviewed Oct 17, 2023

View reviewed changes

roiLeo requested a review from exezbcz October 17, 2023 06:47

prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Oct 17, 2023

using webp

4bc59de

Merge branch 'main' into feat-replace-placeholders

4f31f8b

daiagi approved these changes Oct 18, 2023

View reviewed changes

changing image

8699422

Merge branch 'main' into feat-replace-placeholders

6161311

Merge branch 'main' into feat-replace-placeholders

be2ea40

image changes

e0a1960

Merge branch 'main' into feat-replace-placeholders

5c37130

Merge branch 'main' into feat-replace-placeholders

9699e67

Merge branch 'main' into feat-replace-placeholders

ed9375b

Merge branch 'main' into feat-replace-placeholders

e581394

changing ipfs hash

5c6ed3e

prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Oct 31, 2023

yangwao merged commit b879dad into kodadot:main Nov 1, 2023
12 checks passed

yangwao added the paid pull-request has been paid label Nov 1, 2023

daiagi mentioned this pull request Nov 13, 2023

Size of K placeholder in activity of collection #8029

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#7685 replace placeholders #7698

#7685 replace placeholders #7698

prachi00 commented Oct 17, 2023

kodabot commented Oct 17, 2023

reviewpad bot commented Oct 17, 2023

netlify bot commented Oct 17, 2023 •

edited

Loading

roiLeo left a comment

prachi00 commented Oct 18, 2023

exezbcz commented Oct 18, 2023 •

edited

Loading

prachi00 commented Oct 19, 2023

prury commented Oct 19, 2023

exezbcz commented Oct 20, 2023

exezbcz commented Oct 20, 2023

prachi00 commented Oct 21, 2023

prachi00 commented Oct 21, 2023

prury commented Oct 22, 2023

prachi00 commented Oct 22, 2023

prachi00 commented Oct 24, 2023

roiLeo commented Oct 24, 2023

prachi00 commented Oct 25, 2023

prachi00 commented Oct 26, 2023

daiagi commented Oct 26, 2023

roiLeo commented Oct 26, 2023

prachi00 commented Oct 27, 2023

prachi00 commented Oct 29, 2023

daiagi commented Oct 29, 2023

prachi00 commented Oct 30, 2023

daiagi commented Oct 31, 2023

prachi00 commented Oct 31, 2023

daiagi commented Oct 31, 2023 •

edited

Loading

prachi00 commented Oct 31, 2023

codeclimate bot commented Oct 31, 2023

sonarqubecloud bot commented Oct 31, 2023

prachi00 commented Oct 31, 2023

daiagi commented Oct 31, 2023

yangwao commented Nov 1, 2023

yangwao commented Nov 1, 2023

#7685 replace placeholders #7698

#7685 replace placeholders #7698

Conversation

prachi00 commented Oct 17, 2023

PR Type

Needs QA check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

Copilot Summary

kodabot commented Oct 17, 2023

reviewpad bot commented Oct 17, 2023

netlify bot commented Oct 17, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

roiLeo left a comment

Choose a reason for hiding this comment

prachi00 commented Oct 18, 2023

exezbcz commented Oct 18, 2023 • edited Loading

ZIP

prachi00 commented Oct 19, 2023

prury commented Oct 19, 2023

exezbcz commented Oct 20, 2023

exezbcz commented Oct 20, 2023

prachi00 commented Oct 21, 2023

prachi00 commented Oct 21, 2023

prury commented Oct 22, 2023

prachi00 commented Oct 22, 2023

prachi00 commented Oct 24, 2023

roiLeo commented Oct 24, 2023

prachi00 commented Oct 25, 2023

prachi00 commented Oct 26, 2023

daiagi commented Oct 26, 2023

roiLeo commented Oct 26, 2023

prachi00 commented Oct 27, 2023

prachi00 commented Oct 29, 2023

daiagi commented Oct 29, 2023

prachi00 commented Oct 30, 2023

daiagi commented Oct 31, 2023

prachi00 commented Oct 31, 2023

daiagi commented Oct 31, 2023 • edited Loading

prachi00 commented Oct 31, 2023

codeclimate bot commented Oct 31, 2023

sonarqubecloud bot commented Oct 31, 2023

prachi00 commented Oct 31, 2023

daiagi commented Oct 31, 2023

yangwao commented Nov 1, 2023

yangwao commented Nov 1, 2023

netlify bot commented Oct 17, 2023 •

edited

Loading

exezbcz commented Oct 18, 2023 •

edited

Loading

daiagi commented Oct 31, 2023 •

edited

Loading