Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm update nuxt #7764

Merged
merged 15 commits into from
Oct 21, 2023
Merged

pnpm update nuxt #7764

merged 15 commits into from
Oct 21, 2023

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented Oct 21, 2023

does it build

continue from

@yangwao yangwao requested a review from a team as a code owner October 21, 2023 10:07
@yangwao yangwao requested review from floyd-li and Jarsen136 and removed request for a team October 21, 2023 10:07
@netlify
Copy link

netlify bot commented Oct 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5bf5e67
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6533a2df8c02640008026962
😎 Deploy Preview https://deploy-preview-7764--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Oct 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 21, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Oct 21, 2023

Code Climate has analyzed commit 5bf5e67 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 21, 2023

AI-Generated Summary: This pull request indicates changes in the package.json file primarily reflecting three main modifications. Firstly, the removal of the dependency @ramp-network/ramp-instant-sdk from one location, followed by the addition of the same dependency, but at a different position with the same version. Lastly, there is an update in the nuxt version from ^3.7.4 to ^3.8.0. The changes seem to revolve around a reorganization of dependencies and a version update of the nuxt package as there is no addition or removal of dependencies.

@yangwao yangwao merged commit 41ca473 into main Oct 21, 2023
11 checks passed
@yangwao yangwao deleted the pnpmupdatenuxt branch October 21, 2023 10:12
@yangwao
Copy link
Member Author

yangwao commented Oct 21, 2023

builds, thanks to @roiLeo !

@yangwao yangwao mentioned this pull request Oct 26, 2023
This was referenced Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant