Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fullscreen button not working for videos #7767

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

floyd-li
Copy link
Member

@floyd-li floyd-li commented Oct 21, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
2023-10-21.22.13.14.mov

Copilot Summary

🤖 Generated by Copilot at e8b726c

Improved the layout and responsiveness of the gallery item modal on different screen sizes. Fixed a bug where the modal close button was hidden by the media.

🤖 Generated by Copilot at e8b726c

Sing, O Muse, of the skillful coder who refined the gallery
And made the modal window fit the screens of every size
He added append-to-body and max-height to b-modal
And gave gallery-item-modal-content full width to please the eyes

@floyd-li floyd-li requested a review from a team as a code owner October 21, 2023 14:15
@floyd-li floyd-li requested review from roiLeo and Jarsen136 and removed request for a team October 21, 2023 14:15
@kodabot
Copy link
Collaborator

kodabot commented Oct 21, 2023

WARNING @floyd-li PR for issue #7744 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #7744

@netlify
Copy link

netlify bot commented Oct 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e8b726c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6533dd17cd5a0600087919bb
😎 Deploy Preview https://deploy-preview-7767--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 21, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 21, 2023

Code Climate has analyzed commit e8b726c and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 21, 2023

AI-Generated Summary: This pull request introduces a fix to the fullscreen button functionality on the gallery item component in the Vue codebase. It adjusts the z-index and the class of gallery item media in GalleryItem.vue, allowing the proper functioning of the fullscreen mode toggle. Moreover, it modifies the GalleryItemPreviewer.vue component by appending the fullscreen modal to the body and setting the max height to 100% of the viewport height, as well as adjusting the width property of .gallery-item-modal-content. The changes involve 7 insertions and 2 deletions across 2 files.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.3% 1.3% Duplication

@Jarsen136 Jarsen136 requested a review from prury October 22, 2023 03:50
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Oct 23, 2023
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 23, 2023
@yangwao
Copy link
Member

yangwao commented Oct 24, 2023

Thanks!
pay 30 usd

@yangwao yangwao merged commit feb64d8 into kodadot:main Oct 24, 2023
12 checks passed
@yangwao
Copy link
Member

yangwao commented Oct 24, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.15 USD/DOT ~ 7.229 $DOT
🧗 13rv1SWoLg9Gb3tmvHPZxb7JbVy51BtMziX7k9WQGSJ7Kp3A
🔗 0xf676f022e35cd8a50813817994ec1a7ec5e8b9587cc7c22fa9b1c41dc60a6226

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 24, 2023
This was referenced Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to maximalize videofiles
6 participants