Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clearing identity: Change message #7827

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Oct 25, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

image

Copilot Summary

🤖 Generated by Copilot at e39e241

Improved identity management UI and translations. Added isClearingIdentity variable to IdentityForm.vue to show appropriate action titles when creating or clearing identity. Added translation key for clearing identity and fixed JSON formatting in en.json.

🤖 Generated by Copilot at e39e241

We are the masters of our fate
We create and clear our identity
No one can control our state
We rebel with isClearingIdentity

@Jarsen136 Jarsen136 requested a review from a team as a code owner October 25, 2023 15:55
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team October 25, 2023 15:55
@kodabot
Copy link
Collaborator

kodabot commented Oct 25, 2023

SUCCESS @Jarsen136 PR for issue #7824 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2d8c9eb
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/653a09a3f778a60008500a71
😎 Deploy Preview https://deploy-preview-7827--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 25, 2023

AI-Generated Summary: This pull request contains modifications to the user identity feature in the application. It introduces a new feature to track and display when the system is clearing a user's identity. Two files are changed, namely, IdentityForm.vue and en.json.

In IdentityForm.vue, a reactive reference, isClearingIdentity, is added to track and respond to the status of an identity being cleared. This state is set to true during the deletion process and back to false after the identity is successfully set. The displayed message is then adapted to reflect this state.

In en.json, the localization file, a new entry for 'Clearing Identity' is added to allow the proper display message according to the clearing process's state. This improvement enhances the user experience by giving a clear indication of the ongoing process state.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 25, 2023
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 25, 2023
@roiLeo roiLeo added this pull request to the merge queue Oct 26, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 26, 2023

Code Climate has analyzed commit 2d8c9eb and detected 0 issues on this pull request.

View more on Code Climate.

Merged via the queue into kodadot:main with commit f2d33d0 Oct 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearing identity: Change message
5 participants