-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove hover action on touch device #7889
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request introduces a feature that hides the hover action on touch devices. It modifies three Vue components: ItemsGrid, ItemsGridImage, and ItemsGridImageTokenEntity. It adds checks for "isTouchDevice" and "hideNFTHoverAction" and these parameters are used to control elements' visibility on different screen types. The hover action visibility is deactivated on touch devices to improve user experience and avoid potential issues with hover functionality on such devices. |
Code Climate has analyzed commit e3488b5 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
hmmm, seems that it was a chrome thing, working! |
thanks! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
pay 20 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Clicking on the NFT card now takes you directly to the detail page instead of the hover action buttons.
Before submitting pull request, please make sure:
Optional
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at e3488b5
This pull request adds a feature to hide the buy button for NFTs on touch devices, where hovering is not possible. It uses a
hideAction
prop and a media query hook in theItemsGridImage
andItemsGridImageTokenEntity
components, which are used by theItemsGrid
component.🤖 Generated by Copilot at e3488b5