Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove hover action on touch device #7889

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

newraina
Copy link
Member

@newraina newraina commented Oct 30, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Clicking on the NFT card now takes you directly to the detail page instead of the hover action buttons.

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at e3488b5

This pull request adds a feature to hide the buy button for NFTs on touch devices, where hovering is not possible. It uses a hideAction prop and a media query hook in the ItemsGridImage and ItemsGridImageTokenEntity components, which are used by the ItemsGrid component.

🤖 Generated by Copilot at e3488b5

No buy button on the touch screen
Hide the action, unleash the dream
Media player, your NFT supreme
ItemsGridImage, the component of doom

@newraina newraina requested a review from a team as a code owner October 30, 2023 11:51
@newraina newraina requested review from roiLeo and floyd-li and removed request for a team October 30, 2023 11:51
@kodabot
Copy link
Collaborator

kodabot commented Oct 30, 2023

SUCCESS @newraina PR for issue #7870 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e3488b5
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/653f98bab647160008862eb0
😎 Deploy Preview https://deploy-preview-7889--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 30, 2023

AI-Generated Summary: This pull request introduces a feature that hides the hover action on touch devices. It modifies three Vue components: ItemsGrid, ItemsGridImage, and ItemsGridImageTokenEntity. It adds checks for "isTouchDevice" and "hideNFTHoverAction" and these parameters are used to control elements' visibility on different screen types. The hover action visibility is deactivated on touch devices to improve user experience and avoid potential issues with hover functionality on such devices.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 30, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 30, 2023

Code Climate has analyzed commit e3488b5 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@newraina newraina changed the title feat: hide hover action on touch device feat: remove hover action on touch device Oct 30, 2023
@prury
Copy link
Member

prury commented Oct 30, 2023

hmmm, seems that it was a chrome thing, working!

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 30, 2023
@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

thanks!
pay 20 usd

@yangwao yangwao merged commit 6e258cd into kodadot:main Nov 1, 2023
12 checks passed
@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.35 USD/DOT ~ 4.598 $DOT
🧗 1CAv6Zq3yVxL3eKhC94GWTWVwp1w4jZbqeZ6wXx1rPAhrce
🔗 0xc82855a8fa0828a2d757e92f474dd1ccdc9670be32467b1c7d018205f1a8faf3

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added paid pull-request has been paid and removed paid pull-request has been paid labels Nov 1, 2023
@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.34 USD/DOT ~ 4.608 $DOT
🧗 1CAv6Zq3yVxL3eKhC94GWTWVwp1w4jZbqeZ6wXx1rPAhrce
🔗 0x5d4c5eca26df94ad899a1ca3a7e652c42a9f192dabfbc0105547a0af236e3b88

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 1, 2023
This was referenced Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile hover cards
4 participants